Skip to content

Conversation

krasimirgg
Copy link
Contributor

No functional changes intended.

The 0.1.2 -> 0.1.3 commit vn-ki/gsgdt-rs@3e1dcec renames Node::new to Node::from_list.

No functional changes intended.

The 0.1.2 -> 0.1.3 commit vn-ki/gsgdt-rs@3e1dcec
renames `Node::new` to `Node::from_list`.
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 24, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2021
@krasimirgg krasimirgg marked this pull request as ready for review December 24, 2021 13:42
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Collaborator

bors commented Dec 28, 2021

📌 Commit 9127f49 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2021
@bors
Copy link
Collaborator

bors commented Dec 29, 2021

⌛ Testing commit 9127f49 with merge 6211dd7...

@bors
Copy link
Collaborator

bors commented Dec 29, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6211dd7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 29, 2021
@bors bors merged commit 6211dd7 into rust-lang:master Dec 29, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 29, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6211dd7): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@klensy
Copy link
Contributor

klensy commented Jan 3, 2022

vn-ki/gsgdt-rs#1

And now this version yanked and softlocks cargo update for rustc:

$ cargo update --dry-run
    Updating crates.io index
    Updating git repository `https://github.com/rust-lang/cargo`
    Updating git repository `https://github.com/rust-lang/rust-clippy`
    Updating git repository `https://github.com/rust-lang/rustfmt`
error: failed to select a version for the requirement `gsgdt = "^0.1.3"`
candidate versions found which didn't match: 0.1.2, 0.1.1, 0.1.0
location searched: crates.io index

@krasimirgg krasimirgg deleted the gsgdt-up branch January 3, 2022 19:19
@Mark-Simulacrum
Copy link
Member

Happy to r+ a revert of this PR, though in general a blind cargo update shouldn't be necessary (so I don't think this is actually a problem?)

krasimirgg added a commit to krasimirgg/rust that referenced this pull request Jan 3, 2022
@krasimirgg
Copy link
Contributor Author

Prepared a revert #92532. IMO it may be confusing to depend on a yanked version of a crate here (I'm not sure if it's really breaking some workflows).

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 3, 2022
…acrum

revert rust-lang#92254 "Bump gsgdt to 0.1.3"

This reverts rust-lang#92254 since gsgdt 0.1.3 was yanked: rust-lang#92254 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 4, 2022
…acrum

revert rust-lang#92254 "Bump gsgdt to 0.1.3"

This reverts rust-lang#92254 since gsgdt 0.1.3 was yanked: rust-lang#92254 (comment)
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 4, 2022
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91754 (Modifications to `std::io::Stdin` on Windows so that there is no longer a 4-byte buffer minimum in read().)
 - rust-lang#91884 (Constify `Box<T, A>` methods)
 - rust-lang#92107 (Actually set IMAGE_SCN_LNK_REMOVE for .rmeta)
 - rust-lang#92456 (Make the documentation of builtin macro attributes accessible)
 - rust-lang#92507 (Suggest single quotes when char expected, str provided)
 - rust-lang#92525 (intra-doc: Make `Receiver::into_iter` into a clickable link)
 - rust-lang#92532 (revert rust-lang#92254 "Bump gsgdt to 0.1.3")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants